linux-kernel - Re: [PATCH bpf-next 3/3] bpf: verifier: allocate idmap scratch in verifier env

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a467432f-065a-1b3b-b7eb-7e62f70918bf@gmail.com>
Date:   Thu, 29 Apr 2021 15:52:47 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Lorenz Bauer <lmb@...udflare.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>
Cc:     kernel-team@...udflare.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next 3/3] bpf: verifier: allocate idmap scratch in
 verifier env

On 29/04/2021 14:46, Lorenz Bauer wrote:
> func_states_equal makes a very short lived allocation for idmap,
> probably because it's too large to fit on the stack. However the
> function is called quite often, leading to a lot of alloc / free
> churn. Replace the temporary allocation with dedicated scratch
> space in struct bpf_verifier_env.
> 
> Signed-off-by: Lorenz Bauer <lmb@...udflare.com>
Acked-by: Edward Cree <ecree.xilinx@...il.com>