linux-kernel - Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 23:18:15 +0800 (GMT+08:00)
From:   Jiabing Wan <wanjiabing@...o.com>
To:     Rodrigo Siqueira <Rodrigo.Siqueira@....com>
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        Aric Cyr <aric.cyr@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Wesley Chalmers <Wesley.Chalmers@....com>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>,
        Wayne Lin <Wayne.Lin@....com>,
        Meenakshikumar Somasundaram <meenakshikumar.somasundaram@....com>,
        Chiawen Huang <chiawen.huang@....com>,
        Anson Jacob <Anson.Jacob@....com>,
        Alvin Lee <alvin.lee2@....com>, Eric Yang <Eric.Yang2@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, kael_w@...h.net
Subject: Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

 
>Is your robot public available?

Sorry, I started to write the robot just one week ago.
It is not strong and complete enough so it is not public available now.
But I am still working on it. If complete, it can be public available.

In fact, this patch is catched by the script called checkinclude.pl
in linux/script. The robot just run the script and catch it ;).

There will be more scripts in the robot and I think
it will be public available soon.

>btw, applied to amd-staging-drm-next.

Thank you very much.

>
>Thanks
>On 04/29, Jiabing Wan wrote:
>>  
>> >Nice catch!
>> >
>> >Are you using any tool to identify this problem?
>> 
>> Yes, I have a robot including many detecting scripts :)
>> 
>> >Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>
>> >
>> >On 04/29, Wan Jiabing wrote:
>> >> In commit 482812d56698e ("drm/amd/display: Set max TTU on
>> >> DPG enable"), "hubp.h" was added which caused the duplicate include.
>> >> To be on the safe side, remove the later duplicate include.
>> >> 
>> >> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
>> >> ---
>> >>  drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>> >>  1 file changed, 1 deletion(-)
>> >> 
>> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> >> index 8f0a13807d05..dcaa6b1e16af 100644
>> >> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>> >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> >> @@ -58,7 +58,6 @@
>> >>  #include "dc_link_ddc.h"
>> >>  #include "dm_helpers.h"
>> >>  #include "mem_input.h"
>> >> -#include "hubp.h"
>> >>  
>> >>  #include "dc_link_dp.h"
>> >>  #include "dc_dmub_srv.h"
>> >> -- 
>> >> 2.25.1
>> >> 
>> >
>> >-- 
>> >Rodrigo Siqueira
>> >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cb8ff161b3a904a49e59808d90b0991d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637552958013669698%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=I7AtEiOlzUuRQag7uAuArUvfd64l1b3gstq7ZTeucik%3D&amp;reserved=0
>> 
>> Yours,
>> Wan Jiabing
>> 
>
>-- 
>Rodrigo Siqueira
>https://siqueira.tech

Yours,
Wan Jiabing