linux-kernel - Re: [PATCH 04/12] perf inject: Add facility to do in place update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210429160003.GC4032392@tassilo.jf.intel.com>
Date:   Thu, 29 Apr 2021 09:00:03 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/12] perf inject: Add facility to do in place update

> +		if (!data.force && !inject.in_place_update_dry_run) {
> +			char reply[10];
> +
> +			printf("The input file will be updated in place. OK? (y/n) ");
> +			if (!fgets(reply, sizeof(reply), stdin) || strcmp(reply, "y\n")) {

Interactive questions could break lots of scripting.

Just error out in this case and require the option.