linux-kernel - Re: [PATCH] ssb: Remove redundant assignment to err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 19:21:22 +0200
From:   Michael Büsch <m@...s.ch>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     nathan@...nel.org, ndesaulniers@...gle.com,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] ssb: Remove redundant assignment to err

On Thu, 29 Apr 2021 18:47:10 +0800
Yang Li <yang.lee@...ux.alibaba.com> wrote:

> Variable 'err' is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
> 
> Clean up the following clang-analyzer warning:
> 
> drivers/ssb/main.c:1306:3: warning: Value stored to 'err' is never read
> [clang-analyzer-deadcode.DeadStores]
> drivers/ssb/main.c:1312:3: warning: Value stored to 'err' is never read
> [clang-analyzer-deadcode.DeadStores]
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/ssb/main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index 0a26984..ab23554 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1303,13 +1303,11 @@ static int __init ssb_modinit(void)
>  	if (err) {
>  		pr_err("Broadcom 43xx PCI-SSB-bridge initialization failed\n");
>  		/* don't fail SSB init because of this */
> -		err = 0;
>  	}
>  	err = ssb_host_pcmcia_init();
>  	if (err) {
>  		pr_err("PCMCIA host initialization failed\n");
>  		/* don't fail SSB init because of this */
> -		err = 0;
>  	}
>  	err = ssb_gige_init();
>  	if (err) {


The assignment is there just as a visual guide to tell the reader that
we ignore the error.
However, there's also a comment that says the same thing. Therefore:

Acked-by: Michael Büsch <m@...s.ch>

-- 
Michael

Content of type "application/pgp-signature" skipped