linux-kernel - Re: [PATCH] smp: fix smp_call_function_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 20:26:45 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Borislav Petkov <bp@...e.de>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Juergen Gross <jgross@...e.com>, Jian Cai <jiancai@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Michael Ellerman <mpe@...erman.id.au>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Huang Ying <ying.huang@...el.com>,
        Nathan Chancellor <nathan@...nel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] smp: fix smp_call_function_single_async prototype

On Thu, Apr 29, 2021 at 8:24 PM 'Nick Desaulniers' via Clang Built
Linux <clang-built-linux@...glegroups.com> wrote:
>
> On Thu, Apr 29, 2021 at 11:17 AM Nick Desaulniers
> <ndesaulniers@...gle.com> wrote:
> >
> > (replying manually to
> > https://lore.kernel.org/lkml/20210429150940.3256656-1-arnd@kernel.org/)
> >
> > Thanks for the patch; with this applied I observe the following new warnings
> > though (for x86_64 defconfig; make LLVM=1 LLVM_IAS=1 -j72)
> >
> > kernel/smp.c:515:19: warning: passing 8-byte aligned argument to 32-byte
> > aligned parameter 1 of 'csd_lock_record' may result in an unaligned pointer
> > access [-Walign-mismatch]
> >                 csd_lock_record(csd);
> >                                 ^
> > kernel/smp.c:516:14: warning: passing 8-byte aligned argument to 32-byte
> > aligned parameter 1 of 'csd_unlock' may result in an unaligned pointer access
> > [-Walign-mismatch]
> >                 csd_unlock(csd);
> >                            ^
> > kernel/smp.c:525:14: warning: passing 8-byte aligned argument to 32-byte
> > aligned parameter 1 of 'csd_unlock' may result in an unaligned pointer access
> > [-Walign-mismatch]
> >                 csd_unlock(csd);
> >                            ^
>
> Perhaps roll this into a v2?
>

Right, I just did the same thing. I wonder if I failed to hit those because of
differences in configuration or because I tested the wrong way.

Either way, I'll give it some more time on the randconfig build machine
before I send out v2.

       Arnd