linux-kernel - Re: [PATCH] rcu: Add missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210429183959.GY975577@paulmck-ThinkPad-P17-Gen-1>
Date:   Thu, 29 Apr 2021 11:39:59 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     rcu@...r.kernel.org, joel@...lfernandes.org,
        jiangshanlai@...il.com, mathieu.desnoyers@...icios.com,
        rostedt@...dmis.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu: Add missing __releases() annotation

On Thu, Apr 29, 2021 at 12:12:19AM +0100, Jules Irenge wrote:
> Sparse report a warning at rcu_print_task_stall()
> 
> "warning: context imbalance in rcu_print_task_stall - unexpected unlock"
> 
> The root cause is a missing annotation at  rcu_print_task_stall() function
> 
> Add the missing __releases(rnp->lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>

Good catch, applied, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/tree_stall.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
> index 59b95cc5cbdf..18b2d5274d65 100644
> --- a/kernel/rcu/tree_stall.h
> +++ b/kernel/rcu/tree_stall.h
> @@ -314,6 +314,7 @@ static void rcu_print_detail_task_stall_rnp(struct rcu_node *rnp)
>   * tasks blocked within RCU read-side critical sections.
>   */
>  static int rcu_print_task_stall(struct rcu_node *rnp, unsigned long flags)
> +	__releases(rnp->lock)
>  {
>  	raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
>  	return 0;
> -- 
> 2.31.1
>