linux-kernel - Re: [PATCH 05/12] perf inject: Add --vm-time-correlation option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210429184651.GD4032392@tassilo.jf.intel.com>
Date:   Thu, 29 Apr 2021 11:46:51 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/12] perf inject: Add --vm-time-correlation option

On Thu, Apr 29, 2021 at 03:58:47PM +0300, Adrian Hunter wrote:
>  		evsel->handler = drop_sample;
>  }
>  
> +static int parse_vm_time_correlation(const struct option *opt, const char *str, int unset)
> +{
> +	struct perf_inject *inject = opt->value;
> +	const char *args;
> +	char *dry_run;
> +
> +	if (unset)
> +		return 0;
> +
> +	inject->itrace_synth_opts.set = true;
> +	inject->itrace_synth_opts.vm_time_correlation = true;
> +	inject->in_place_update = true;
> +
> +	if (!str)
> +		return 0;
> +
> +	dry_run = strstr(str, "dry-run");

Please use a proper split, otherwise it cannot be extended.

Right now just !strcmp is enough I guess

>