linux-kernel - Re: 答复: [PATCH v3] mm/compaction:let proactive compaction order configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 15:45:37 -0400
From:   Rafael Aquini <aquini@...hat.com>
To:     "Chu,Kaiping" <chukaiping@...du.com>
Cc:     "mcgrof@...nel.org" <mcgrof@...nel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "yzaikin@...gle.com" <yzaikin@...gle.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "nigupta@...dia.com" <nigupta@...dia.com>,
        "bhe@...hat.com" <bhe@...hat.com>,
        "khalid.aziz@...cle.com" <khalid.aziz@...cle.com>,
        "iamjoonsoo.kim@....com" <iamjoonsoo.kim@....com>,
        "mateusznosek0@...il.com" <mateusznosek0@...il.com>,
        "sh_def@....com" <sh_def@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: 答复: [PATCH v3]
 mm/compaction:let proactive compaction order configurable

On Wed, Apr 28, 2021 at 01:17:40AM +0000, Chu,Kaiping wrote:
> Please see my answer inline.
> 
> -----邮件原件-----
> 发件人: Rafael Aquini <aquini@...hat.com> 
> 发送时间: 2021年4月26日 9:31
> 收件人: Chu,Kaiping <chukaiping@...du.com>
> 抄送: mcgrof@...nel.org; keescook@...omium.org; yzaikin@...gle.com; akpm@...ux-foundation.org; vbabka@...e.cz; nigupta@...dia.com; bhe@...hat.com; khalid.aziz@...cle.com; iamjoonsoo.kim@....com; mateusznosek0@...il.com; sh_def@....com; linux-kernel@...r.kernel.org; linux-fsdevel@...r.kernel.org; linux-mm@...ck.org
> 主题: Re: [PATCH v3] mm/compaction:let proactive compaction order configurable
> 
> On Sun, Apr 25, 2021 at 09:21:02AM +0800, chukaiping wrote:
> > Currently the proactive compaction order is fixed to 
> > COMPACTION_HPAGE_ORDER(9), it's OK in most machines with lots of 
> > normal 4KB memory, but it's too high for the machines with small 
> > normal memory, for example the machines with most memory configured as 
> > 1GB hugetlbfs huge pages. In these machines the max order of free 
> > pages is often below 9, and it's always below 9 even with hard 
> > compaction. This will lead to proactive compaction be triggered very 
> > frequently. In these machines we only care about order of 3 or 4.
> > This patch export the oder to proc and let it configurable by user, 
> > and the default value is still COMPACTION_HPAGE_ORDER.
> > 
> > Signed-off-by: chukaiping <chukaiping@...du.com>
> > Reported-by: kernel test robot <lkp@...el.com>
> 
> Two minor nits on the commit log message: 
> * there seems to be a whitespage missing in your short log: 
>   "... mm/compaction:let ..."
> --> I will fix it in next patch.
> 
> * has the path really been reported by a test robot?
> --> Yes. There is a compile error in v1, I fixed it in v2.
>

So, no... the test robot should not be listed as Reported-by.