linux-kernel - Re: [PATCH] Revert "crypto: cavium/nitrox - add an error message to explain the failure of pci_request_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210429001834.liqriwtjetecfnr6@gondor.apana.org.au>
Date:   Thu, 29 Apr 2021 08:18:34 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] Revert "crypto: cavium/nitrox - add an error message to
 explain the failure of pci_request_mem_regions"

On Wed, Apr 28, 2021 at 09:49:31AM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 9fcddaf2e28d779cb946d23838ba6d50f299aa80 as it was
> submitted under a fake name and we can not knowingly accept anonymous
> contributions to the repository.
> 
> This commit was part of a submission "test" to the Linux kernel
> community by some "researchers" at umn.edu.  As outlined at:
> 	https://www-users.cs.umn.edu/%7Ekjlu/papers/full-disclosure.pdf
> it was done so as an attempt to submit a known-buggy patch to see if it
> could get by our review.  However, the submission turned out to actually
> be correct, and not have a bug in it as the author did not understand
> how the PCI driver model works at all, and so the submission was
> accepted.
> 
> As this change is of useless consequence, there is no loss of
> functionality in reverting it.
> 
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Cc: linux-crypto@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/crypto/cavium/nitrox/nitrox_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> Herbert, I will be taking this as part of my larger "revert buggy patch
> submissions from umn.edu" tree, so no need for you to take this in your
> tree at this point in time, I just wanted to give you a heads up as to
> what is happening here.

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt