linux-kernel - Re: [PATCH] floppy: Remove redundant assignment to nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <691dcf37-a771-26f1-cd6d-ee49226550a3@linux.com>
Date:   Fri, 30 Apr 2021 12:56:20 +0300
From:   Denis Efremov <efremov@...ux.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] floppy: Remove redundant assignment to nr_sectors

Hi,

On 4/30/21 12:26 PM, Jiapeng Chong wrote:
> Variable nr_sectors is set to zero but this value is never
> read as it is overwritten later on, hence it is a redundant
> assignment and can be removed.
> 
> Clean up the following clang-analyzer warning:
> 
> drivers/block/floppy.c:2333:2: warning: Value stored to 'nr_sectors' is
> never read [clang-analyzer-deadcode.DeadStores].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Looks good, applied.
https://github.com/evdenis/linux-floppy/commit/a2d3f991fb51beb1376fb257a316e9b9e3c99737

I slightly changed the title. I guess this will go with other cleanup patches
to 5.14 release. Jens already merged 5.13 patches to master.

Thanks,
Denis

> ---
>  drivers/block/floppy.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 8a9d222..e96ad5b 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2330,7 +2330,6 @@ static void rw_interrupt(void)
>  	if (!drive_state[current_drive].first_read_date)
>  		drive_state[current_drive].first_read_date = jiffies;
>  
> -	nr_sectors = 0;
>  	ssize = DIV_ROUND_UP(1 << raw_cmd->cmd[SIZECODE], 4);
>  
>  	if (reply_buffer[ST1] & ST1_EOC)
>