linux-kernel - Re: [PATCH v4 5/9] staging: media: atomisp: reformat code comment blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <693e054f-6a7b-d9e7-a72a-07d7fa295487@xs4all.nl>
Date:   Fri, 30 Apr 2021 12:04:33 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Deepak R Varma <drv@...lo.com>,
        Fabio Aiuto <fabioaiuto83@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/9] staging: media: atomisp: reformat code comment
 blocks

On 29/04/2021 13:49, Deepak R Varma wrote:
> On Thu, Apr 29, 2021 at 09:06:12AM +0200, Fabio Aiuto wrote:
>> Hi Deepak,
> 
> Hello Fabio :)
> 
>>
>> On Wed, Apr 28, 2021 at 11:38:45PM +0530, Deepak R Varma wrote:
>>> Reformat code comment blocks according to the coding style guidelines.
>>> This resolves different checkpatch script WARNINGs around block comments.
>>>
>>> Suggested-by: Fabio Aiuto <fabioaiuto83@...il.com>
>>> Signed-off-by: Deepak R Varma <drv@...lo.com>
>>> ---
>>>
>>> Changes since v3:
>>>    - Include additional header files in the clean up
>>> Changes since v2:
>>>    - Tag Fabio Auito for the patch suggestion
>>>
>>> diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.h b/drivers/staging/media/atomisp/i2c/mt9m114.h
>>> index 787bbf59e895..aad98f37aaa6 100644
>>> --- a/drivers/staging/media/atomisp/i2c/mt9m114.h
>>> +++ b/drivers/staging/media/atomisp/i2c/mt9m114.h
>>> @@ -765,7 +765,8 @@ static struct misensor_reg const mt9m114_common[] = {
>>>  	{MISENSOR_16BIT, 0xC868, 0x0280}, /* cam_output_width = 952 */
>>>  	{MISENSOR_16BIT, 0xC86A, 0x01E0}, /* cam_output_height = 538 */
>>>  	/* LOAD = Step3-Recommended
>>> -	 * Patch,Errata and Sensor optimization Setting */
>>> +	 * Patch,Errata and Sensor optimization Setting
>>> +	 */
>>
>> 	/*
>> 	 * LOAD = Step3-Recommended
>>
>> :(
> 
> oops... sorry for the oversight. Not sure how I missed it.
> I will wait for any other feedback on other patches and send
> in a corrected version shortly.

I've fixed this up myself.

I'm taking this series and make a PR for this, wrapping up these
atomisp cleanups.

If you plan any more cleanups, then please do this on top of this
branch: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v5.14-out1

That contains all pending cleanups for staging/media.

Regards,

	Hans

> 
> Thank you,
> deepak.
> 
> 
> 
>>
>>
>>>  	{MISENSOR_16BIT, 0x316A, 0x8270}, /* DAC_TXLO_ROW */
>>>
>>
>> thank you,
>>
>> fabio
> 
>