linux-kernel - Aw: Re: [PATCH] musb: mediatek: rename driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Apr 2021 15:30:39 +0200
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Frank Wunderlich <linux@...web.de>,
        linux-mediatek@...ts.infradead.org, Bin Liu <b-liu@...com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        David Miller <davem@...emloft.net>,
        DENG Qingfang <dqfext@...il.com>
Subject: Aw: Re: [PATCH] musb: mediatek: rename driver

Hi Grek

the problem is that the name mediatek.ko does not point to musb-subsystem. I had discussed with Min Gao (author of this driver) some time ago about this as the name may conflict with other modules (don't remember which was that).
We have searched issue using the driver on my board (not yet resolved).

if the module is loaded it shows (based on name) only "mediatek" and user does not know that is the mediatek musb driver, not very good in my eyes as mediatek is a vendor designing many different hardware and so drivers. Imho the module-name should at least give a clue to the subsystem to avoid confusion/conflicts

Now the discussion comes up again here for a new driver:
https://patchwork.kernel.org/project/linux-mediatek/cover/20210429062130.29403-1-dqfext@gmail.com/#24148777

so i decided to rebase and post my patch created in past to clean this up.

and yes this can result in user-space issues depending on the name...because of this i have not added stable-tag ;)

regards Frank

> Gesendet: Freitag, 30. April 2021 um 14:54 Uhr
> Von: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>

> On Fri, Apr 30, 2021 at 02:43:17PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@...lic-files.de>
> >
> > currently unspecific mediatek.ko is built,
> > change this by adding subsystem
>
> I am sorry, I do not understand this changelog text.  What are you doing
> here and why?
>
> > Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> > ---
> >  drivers/usb/musb/Makefile                   | 2 +-
> >  drivers/usb/musb/{mediatek.c => musb_mtk.c} | 0
>
> Why rename this file, will that not break existing setups that expect
> the module to be named this?
>
> thanks,
>
> greg k-h