linux-kernel - Re: [PATCH 01/12] dt-bindings: soc: qcom: aoss: Drop power-domain bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Apr 2021 09:59:50 -0500
From:   Rob Herring <robh@...nel.org>
To:     Sibi Sankar <sibis@...eaurora.org>
Cc:     bjorn.andersson@...aro.org, ulf.hansson@...aro.org,
        mathieu.poirier@...aro.org, swboyd@...omium.org, rjw@...ysocki.net,
        agross@...nel.org, ohad@...ery.com, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, dianders@...omium.org,
        rishabhb@...eaurora.org, sidgup@...eaurora.org
Subject: Re: [PATCH 01/12] dt-bindings: soc: qcom: aoss: Drop power-domain
 bindings

On Fri, Apr 16, 2021 at 05:33:47PM +0530, Sibi Sankar wrote:
> Drop power-domain bindings exposed by AOSS QMP node.

That's obvious from the diff. The commit msg should tell us why.

> 
> Signed-off-by: Sibi Sankar <sibis@...eaurora.org>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt       | 16 ++--------------
>  1 file changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> index 783dc81b0f26..c0ae051a5b76 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> @@ -9,8 +9,7 @@ Messaging Protocol (QMP)
>  
>  The AOSS side channel exposes control over a set of resources, used to control
>  a set of debug related clocks and to affect the low power state of resources
> -related to the secondary subsystems. These resources are exposed as a set of
> -power-domains.
> +related to the secondary subsystems.
>  
>  - compatible:
>  	Usage: required
> @@ -46,14 +45,6 @@ power-domains.
>  	Definition: must be 0
>  		    The single clock represents the QDSS clock.
>  
> -- #power-domain-cells:
> -	Usage: optional
> -	Value type: <u32>
> -	Definition: must be 1
> -		    The provided power-domains are:
> -		    CDSP state (0), LPASS state (1), modem state (2), SLPI
> -		    state (3), SPSS state (4) and Venus state (5).
> -
>  = SUBNODES
>  The AOSS side channel also provides the controls for three cooling devices,
>  these are expressed as subnodes of the QMP node. The name of the node is used
> @@ -66,8 +57,7 @@ to identify the resource and must therefor be "cx", "mx" or "ebi".
>  
>  = EXAMPLE
>  
> -The following example represents the AOSS side-channel message RAM and the
> -mechanism exposing the power-domains, as found in SDM845.
> +The following example represents the AOSS side-channel message RAM as found in SDM845.
>  
>    aoss_qmp: qmp@...0000 {
>  	  compatible = "qcom,sdm845-aoss-qmp";
> @@ -75,8 +65,6 @@ mechanism exposing the power-domains, as found in SDM845.
>  	  interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
>  	  mboxes = <&apss_shared 0>;
>  
> -	  #power-domain-cells = <1>;
> -
>  	  cx_cdev: cx {
>  		#cooling-cells = <2>;
>  	  };
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>