linux-kernel - Re: [PATCH v4 15/79] media: sh_vou: fix pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210430174005.00007dc4@Huawei.com>
Date:   Fri, 30 Apr 2021 17:40:05 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
CC:     <linuxarm@...wei.com>, <mauro.chehab@...wei.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "Hans Verkuil" <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>
Subject: Re: [PATCH v4 15/79] media: sh_vou: fix pm_runtime_get_sync() usage
 count

On Wed, 28 Apr 2021 16:51:36 +0200
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:

> The pm_runtime_get_sync() internally increments the
> dev->power.usage_count without decrementing it, even on errors.
> Replace it by the new pm_runtime_resume_and_get(), introduced by:
> commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> in order to properly decrement the usage counter and avoid memory
> leaks.
> 
> While here, check if the PM runtime error was caught at open time.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> ---
>  drivers/media/platform/sh_vou.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c
> index 4ac48441f22c..ca4310e26c49 100644
> --- a/drivers/media/platform/sh_vou.c
> +++ b/drivers/media/platform/sh_vou.c
> @@ -1133,7 +1133,11 @@ static int sh_vou_open(struct file *file)
>  	if (v4l2_fh_is_singular_file(file) &&
>  	    vou_dev->status == SH_VOU_INITIALISING) {
>  		/* First open */
> -		pm_runtime_get_sync(vou_dev->v4l2_dev.dev);
> +		err = pm_runtime_resume_and_get(vou_dev->v4l2_dev.dev);
> +		if (err < 0) {
> +			v4l2_fh_release(file);
> +			goto done_open;
> +		}
>  		err = sh_vou_hw_init(vou_dev);
>  		if (err < 0) {
>  			pm_runtime_put(vou_dev->v4l2_dev.dev);