linux-kernel - Re: [PATCH v4 27/79] media: i2c: ak7375: use pm_runtime_resume_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210430181455.00006c49@Huawei.com>
Date:   Fri, 30 Apr 2021 18:14:55 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
CC:     <linuxarm@...wei.com>, <mauro.chehab@...wei.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>
Subject: Re: [PATCH v4 27/79] media: i2c: ak7375: use
 pm_runtime_resume_and_get()

On Wed, 28 Apr 2021 16:51:48 +0200
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:

> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
> 
> Use the new API, in order to cleanup the error check logic.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/media/i2c/ak7375.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/media/i2c/ak7375.c b/drivers/media/i2c/ak7375.c
> index e1f94ee0f48f..40b1a4aa846c 100644
> --- a/drivers/media/i2c/ak7375.c
> +++ b/drivers/media/i2c/ak7375.c
> @@ -87,15 +87,7 @@ static const struct v4l2_ctrl_ops ak7375_vcm_ctrl_ops = {
>  
>  static int ak7375_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
>  {
> -	int ret;
> -
> -	ret = pm_runtime_get_sync(sd->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(sd->dev);
> -		return ret;
> -	}
> -
> -	return 0;
> +	return pm_runtime_resume_and_get(sd->dev);
>  }
>  
>  static int ak7375_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)