linux-kernel - RE: [RFC PATCH v6 1/4] topology: Represent clusters of CPUs within a die

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2fcccd7430f945e9badf693627298fdd@hisilicon.com>
Date:   Fri, 30 Apr 2021 03:46:04 +0000
From:   "Song Bao Hua (Barry Song)" <song.bao.hua@...ilicon.com>
To:     Andrew Jones <drjones@...hat.com>
CC:     "aubrey.li@...ux.intel.com" <aubrey.li@...ux.intel.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "bsegall@...gle.com" <bsegall@...gle.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "dietmar.eggemann@....com" <dietmar.eggemann@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "guodong.xu@...aro.org" <guodong.xu@...aro.org>,
        "hpa@...or.com" <hpa@...or.com>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "Liguozhu (Kenneth)" <liguozhu@...ilicon.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxarm@...neuler.org" <linuxarm@...neuler.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "msys.mizuma@...il.com" <msys.mizuma@...il.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "Zengtao (B)" <prime.zeng@...ilicon.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "sudeep.holla@....com" <sudeep.holla@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "tim.c.chen@...ux.intel.com" <tim.c.chen@...ux.intel.com>,
        "valentin.schneider@....com" <valentin.schneider@....com>,
        "vincent.guittot@...aro.org" <vincent.guittot@...aro.org>,
        "will@...nel.org" <will@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>, "xuwei (O)" <xuwei5@...wei.com>,
        yangyicong <yangyicong@...wei.com>,
        "tiantao (H)" <tiantao6@...ilicon.com>
Subject: RE: [RFC PATCH v6 1/4] topology: Represent clusters of CPUs within a
 die



> -----Original Message-----
> From: Andrew Jones [mailto:drjones@...hat.com]
> Sent: Wednesday, April 28, 2021 9:48 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@...ilicon.com>
> Cc: aubrey.li@...ux.intel.com; bp@...en8.de; bsegall@...gle.com;
> catalin.marinas@....com; dietmar.eggemann@....com;
> gregkh@...uxfoundation.org; guodong.xu@...aro.org; hpa@...or.com; Jonathan
> Cameron <jonathan.cameron@...wei.com>; juri.lelli@...hat.com;
> lenb@...nel.org; Liguozhu (Kenneth) <liguozhu@...ilicon.com>;
> linux-acpi@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; linuxarm@...neuler.org; mark.rutland@....com;
> mgorman@...e.de; mingo@...hat.com; msys.mizuma@...il.com;
> peterz@...radead.org; Zengtao (B) <prime.zeng@...ilicon.com>;
> rjw@...ysocki.net; rostedt@...dmis.org; sudeep.holla@....com;
> tglx@...utronix.de; tim.c.chen@...ux.intel.com; valentin.schneider@....com;
> vincent.guittot@...aro.org; will@...nel.org; x86@...nel.org; xuwei (O)
> <xuwei5@...wei.com>; yangyicong <yangyicong@...wei.com>
> Subject: Re: [RFC PATCH v6 1/4] topology: Represent clusters of CPUs within
> a die
> 
> On 20/04/2021 12:18, Barry Song wrote:
> ...
> > Currently the ID provided is the offset of the Processor
> > Hierarchy Nodes Structure within PPTT.  Whilst this is unique
> > it is not terribly elegant so alternative suggestions welcome.
> >
> 
> The ACPI table offsets are consistent with how other topology IDs are
> generated. I once tried to make them a little more human friendly with
> [1], but it was nacked.
> 
> [1] https://lore.kernel.org/lkml/20180629132934.GA16282@e107155-lin/t/
> 

Ideally, we are going to check if cluster node has a valid UID,
if yes, read this ID; otherwise, fall back to use offset.

Will move to that way in next version.

> Thanks,
> drew

Thanks
Barry