linux-kernel - Re: [PATCH] nvme: fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Apr 2021 14:00:57 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Prike Liang <Prike.Liang@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rajat Jain <rajatja@...gle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-pci <linux-pci@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: fix unused variable warning

On Fri, Apr 30, 2021 at 09:34:55PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 30, 2021 at 8:57 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
> > On Wed, Apr 21, 2021 at 04:04:20PM +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@...db.de>
> > >
> > > The function was introduced with a variable that is never referenced:
> > >
> > > drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> > > drivers/pci/quirks.c:312:25: warning: unused variable 'rdev' [-Wunused-variable]
> > >
> > > Fixes: 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
> >
> > I guess this refers to https://lore.kernel.org/linux-nvme/1618458725-17164-1-git-send-email-Prike.Liang@amd.com/
> >
> > But I don't know what the SHA1 means; I can't find it in linux-next or
> > my tree.
> 
> $ git tag --contains 9597624ef606
> next-20210416
> next-20210419
> next-20210420
> 
> Something is wrong with your tree.

I think what's wrong is that it doesn't appear in the *current*
linux-next (next-20210430) and I don't have all the old linux-next
objects.

It was in next-20210420, but seems to have been dropped since then:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/linux/pci.h?h=next-20210420&id=9597624ef6067bab1500d0273a43d4f90e62e929