linux-kernel - Re: [PATCH] KEYS: trusted: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIxfehTLhWe58sNE@erythro>
Date:   Fri, 30 Apr 2021 15:50:18 -0400
From:   Ben Boeckel <me@...boeckel.net>
To:     trix@...hat.com
Cc:     jejb@...ux.ibm.com, jarkko@...nel.org, zohar@...ux.ibm.com,
        dhowells@...hat.com, jmorris@...ei.org, serge@...lyn.com,
        linux-integrity@...r.kernel.org, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, Colin King <colin.king@...onical.com>
Subject: Re: [PATCH] KEYS: trusted: fix memory leak

On Fri, Apr 30, 2021 at 11:58:10 -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Static analysis reports this problem
> trusted-keys/trusted_tpm1.c:496:10: warning: Potential memory leak
>   return ret;
>          ^~~
> 
> In tpm_seal() some failure handling returns directly, without
> freeing memory.
> 
> Fixes: 5df16caada3f ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  security/keys/trusted-keys/trusted_tpm1.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/security/keys/trusted-keys/trusted_tpm1.c b/security/keys/trusted-keys/trusted_tpm1.c
> index 469394550801..aa108bea6739 100644
> --- a/security/keys/trusted-keys/trusted_tpm1.c
> +++ b/security/keys/trusted-keys/trusted_tpm1.c
> @@ -493,10 +493,12 @@ static int tpm_seal(struct tpm_buf *tb, uint16_t keytype,
>  
>  	ret = tpm_get_random(chip, td->nonceodd, TPM_NONCE_SIZE);
>  	if (ret < 0)
> -		return ret;
> +		goto out;
>  
> -	if (ret != TPM_NONCE_SIZE)
> -		return -EIO;
> +	if (ret != TPM_NONCE_SIZE) {
> +		ret = -EIO;
> +		goto out;
> +	}
>  
>  	ordinal = htonl(TPM_ORD_SEAL);
>  	datsize = htonl(datalen);

I see this patch also submitted by Colin (Cc'd) in Message-Id:

    <20210430113724.110746-1-colin.king@...onical.com>

To my eyes, the commit message seems a bit better over there.

--Ben