linux-kernel - Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YI1IMG8tCvvRMq3i@kroah.com>
Date:   Sat, 1 May 2021 14:23:12 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ashish Kalra <eashishkalra@...il.com>
Cc:     Ivan Safonov <insafonov@...il.com>,
        Abheek Dhawan <adawesomeguy222@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Waiman Long <longman@...hat.com>,
        Pritthijit Nath <pritthijit.nath@...oud.com>,
        Allen Pais <apais@...ux.microsoft.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument
 1 (different address spaces)

On Sat, May 01, 2021 at 05:09:28PM +0530, Ashish Kalra wrote:
> Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while calling memdup_user, instead of type casting it here, its better to change data type for data inside p80211ioctl_req to include __user.

Please properly line-wrap your changelog comments.

Can you fix it up and resend it as v3?

thanks,

greg k-h