linux-kernel - Re: [PATCH 1/2] tracing: Add a trace for task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210501091104.418765bd@oasis.local.home>
Date:   Sat, 1 May 2021 09:11:04 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     <Peter.Enderborg@...y.com>
Cc:     <ebiederm@...ssion.com>, <linux-kernel@...r.kernel.org>,
        <mingo@...hat.com>, <akpm@...ux-foundation.org>,
        <peterz@...radead.org>, <ast@...nel.org>,
        <christian.brauner@...ntu.com>, <dave@...olabs.net>,
        <walken@...gle.com>, <jannh@...gle.com>,
        <mathieu.desnoyers@...icios.com>, <christophe.leroy@....fr>,
        <minchan@...nel.org>
Subject: Re: [PATCH 1/2] tracing: Add a trace for task_exit

On Sat, 1 May 2021 09:29:41 +0000
<Peter.Enderborg@...y.com> wrote:

> On 4/30/21 7:48 PM, Eric W. Biederman wrote:
> > Peter Enderborg <peter.enderborg@...y.com> writes:
> >  
> >> This is the peer functions to task_rename and task_newtask.
> >> With this we get hole "life-cycle" of task and can easily
> >> see short livied task and their exit status.  
> > This patch is incorrect.  The location you are dealing with is not part
> > of task exit.  The location you have instrumented is part of reaping a
> > task which can come arbitrarily long after the task exits.  
> 
> That is what it aiming. When using this as tool for userspace you
> would like to know when the task is done. When it no longer
> holds any thing that might have any impact. If you think the
> exit imply something more specific I can change the name.
> 
> I thought exit was a good name, it is in in exit.c.
> 
> Will the name task_done, task_finished or task_reaped work for you?

I think "task_reaped" is probably the best name, and the most
descriptive of what happened.

-- Steve