linux-kernel - [PATCH-V3] fs/btrfs: Fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat,  1 May 2021 02:11:36 +0100
From:   Khaled ROMDHANI <khaledromdhani216@...il.com>
To:     clm@...com, josef@...icpanda.com, dsterba@...e.com
Cc:     Khaled ROMDHANI <khaledromdhani216@...il.com>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: [PATCH-V3] fs/btrfs: Fix uninitialized variable

The variable 'zone' is uninitialized which
introduce some build warning when introduced
within the switch.

Fix that by changing the passed condition:
Catch explicitly any invalid 'mirror' value
as an assertion failure.

Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Khaled ROMDHANI <khaledromdhani216@...il.com>
---
V3: catch explicitly invalid mirror value
V2: force assertion failure by zeroing the zone variable
V1: initialize the zone variable
---
 fs/btrfs/zoned.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 432509f4b3ac..8250ab3f0868 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -144,7 +144,7 @@ static inline u32 sb_zone_number(int shift, int mirror)
 	case 1: zone = 1ULL << (BTRFS_SB_LOG_FIRST_SHIFT - shift); break;
 	case 2: zone = 1ULL << (BTRFS_SB_LOG_SECOND_SHIFT - shift); break;
 	default:
-		ASSERT(zone);
+		ASSERT((u32)mirror < 3);
 		break;
 	}
 

base-commit: c05b2a58c9ed11bd753f1e64695bd89da715fbaa
-- 
2.17.1