linux-kernel - Re: [rcu:dev.2021.04.20a 98/101] kernel/rcu/tasks.h:1404:20: error: static declaration of 'show_rcu_tasks_gp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Apr 2021 21:26:43 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [rcu:dev.2021.04.20a 98/101] kernel/rcu/tasks.h:1404:20: error:
 static declaration of 'show_rcu_tasks_gp_kthreads' follows non-static
 declaration

On Sat, May 01, 2021 at 09:48:46AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2021.04.20a
> head:   fe7d174b033dcf9367759b3c14febb31525aad39
> commit: a1ec494e1eef0c72d8f89bbf916a4b291273d2e5 [98/101] tasks-rcu: Make show_rcu_tasks_gp_kthreads() be static inline
> config: arm-spear13xx_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=a1ec494e1eef0c72d8f89bbf916a4b291273d2e5
>         git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
>         git fetch --no-tags rcu dev.2021.04.20a
>         git checkout a1ec494e1eef0c72d8f89bbf916a4b291273d2e5
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm 

This has since been obsoleted by b5200edc0c43 ("tasks-rcu: Make
show_rcu_tasks_gp_kthreads() be static inline").

						Thanx, Paul

> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from kernel/rcu/update.c:584:
> >> kernel/rcu/tasks.h:1404:20: error: static declaration of 'show_rcu_tasks_gp_kthreads' follows non-static declaration
>     1404 | static inline void show_rcu_tasks_gp_kthreads(void) {}
>          |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    In file included from kernel/rcu/update.c:49:
>    kernel/rcu/rcu.h:440:6: note: previous declaration of 'show_rcu_tasks_gp_kthreads' was here
>      440 | void show_rcu_tasks_gp_kthreads(void);
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/show_rcu_tasks_gp_kthreads +1404 kernel/rcu/tasks.h
> 
>   1401	
>   1402	#else /* #ifdef CONFIG_TASKS_RCU_GENERIC */
>   1403	static inline void rcu_tasks_bootup_oddness(void) {}
> > 1404	static inline void show_rcu_tasks_gp_kthreads(void) {}
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org