linux-kernel - Re: [PATCH 5.10 1/2] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_gen2_enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YI6HFNNvzuHnv5VU@kroah.com>
Date:   Sun, 2 May 2021 13:03:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jari Ruusu <jariruusu@...rs.sourceforge.net>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jiri Kosina <jkosina@...e.cz>,
        Kalle Valo <kvalo@...eaurora.org>
Subject: Re: [PATCH 5.10 1/2] iwlwifi: Fix softirq/hardirq disabling in
 iwl_pcie_gen2_enqueue_hcmd()

On Sat, May 01, 2021 at 10:12:42AM +0300, Jari Ruusu wrote:
> Greg Kroah-Hartman wrote:
> > From: Jiri Kosina <jkosina@...e.cz>
> > 
> > commit e7020bb068d8be50a92f48e36b236a1a1ef9282e upstream.
> > 
> > Analogically to what we did in 2800aadc18a6 ("iwlwifi: Fix softirq/hardirq
> > disabling in iwl_pcie_enqueue_hcmd()"), we must apply the same fix to
> > iwl_pcie_gen2_enqueue_hcmd(), as it's being called from exactly the same
> > contexts.
> 
> Greg,
> This patch and above mentioned earlier patch
> "iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()",
> upstream commit 2800aadc18a64c96b051bcb7da8a7df7d505db3f, both need
> to be backported to older kernels too.
> 
> I see that there are trivial context rejects if/when you attempt to
> apply those patches to older kernels. Those trivial context rejects
> should not prevent backporting them. Maybe run both patches through sed?
> 
> sed -e s/iwl_txq_space/iwl_queue_space/ -e s/iwl_txq_get_/iwl_pcie_get_/
> 
> My ability test in-tree iwlwifi is limited. I compile out-of-tree
> iwlwifi source, and testing that is limited to pinging mobile-wifi
> router that does not have SIM-card.

If you could provide backported patches to those kernels you think this
is needed to, I can take them directly.  Otherwise running sed isn't
always the easiest thing to do on my end :)

thanks

greg k-h