linux-kernel - Re: [PATCH v6 1/3] reset: add missing empty function reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210503185639.GA993318@bjorn-Precision-5520>
Date:   Mon, 3 May 2021 13:56:39 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jim Quinlan <jim2101024@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Amjad Ouled-Ameur <aouledameur@...libre.com>,
        linux-pci@...r.kernel.org,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        bcm-kernel-feedback-list@...adcom.com, james.quinlan@...adcom.com,
        stable@...r.kernel.org, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/3] reset: add missing empty function
 reset_control_rearm()

On Fri, Apr 30, 2021 at 11:21:54AM -0400, Jim Quinlan wrote:
> All other functions are defined for when CONFIG_RESET_CONTROLLER
> is not set.
> 
> Fixes: 557acb3d2cd9 ("reset: make shared pulsed reset controls re-triggerable")
> CC: stable@...r.kernel.org # v5.11+
> Signed-off-by: Jim Quinlan <jim2101024@...il.com>

Philipp, I'd like to merge this via the PCI tree since the brcmstb
patch depends on it.  It looks correct to me, but I'd really like to
have your ack before merging it.

> ---
>  include/linux/reset.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index b9109efa2a5c..9700124affa3 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -47,6 +47,11 @@ static inline int reset_control_reset(struct reset_control *rstc)
>  	return 0;
>  }
>  
> +static inline int reset_control_rearm(struct reset_control *rstc)
> +{
> +	return 0;
> +}
> +
>  static inline int reset_control_assert(struct reset_control *rstc)
>  {
>  	return 0;
> -- 
> 2.17.1
>