linux-kernel - Re: [PATCH 2/2] lib/test: convert lib/test_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGS_qxoqFHdqoqFEnNJc5_2jspzaHy+WoctiUnRndScXyrKbew@mail.gmail.com>
Date:   Mon, 3 May 2021 14:05:23 -0700
From:   Daniel Latypov <dlatypov@...gle.com>
To:     Nico Pache <npache@...hat.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        David Gow <davidgow@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        KUnit Development <kunit-dev@...glegroups.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 2/2] lib/test: convert lib/test_list_sort.c to use KUnit

I've left the names as-is for now in v2,
https://lore.kernel.org/linux-kselftest/20210503205835.1370850-2-dlatypov@google.com
I could send a v3 w/ the rename and see if anyone complains, but I'm
tempted to push that off.


On Thu, Apr 22, 2021 at 1:43 PM Daniel Latypov <dlatypov@...gle.com> wrote:
>
> On Thu, Apr 22, 2021 at 1:16 PM Nico Pache <npache@...hat.com> wrote:
> >
> > Hi,
> >
> > Can we change this to CONFIG_LIST_SORT_KUNIT_TEST to follow the convention used by other KUNIT tests?
>
> I mentioned this in the commit description briefly, but I don't know
> who is using this test. Nor do I really know who to ask.
> So I didn't want to risk breaking anyone's workflow for now (more than
> now requiring them to set CONFIG_KUNIT=y/m).
>
> Side note: maybe CONFIG_KUNIT can default to =y when DEBUG_KERNEL is set?
> Then there'd be even less change than how this worked before...
>
> If it's not a concern, I'll happily update the file name and config
> option to follow the conventions.
>
> >
> > Maintainers? thoughts? I recently posted patches to convert some of the other tests that break this format [1].
> >
> > Cheers,
> >
> > -- Nico
> >
> > [1] - https://lkml.org/lkml/2021/4/14/310
> >
> > On 4/21/21 2:32 PM, Daniel Latypov wrote:
> > > [SNIP...]
> > >  config TEST_LIST_SORT
> > > -     tristate "Linked list sorting test"
> > > -     depends on DEBUG_KERNEL || m
> > > +     tristate "Linked list sorting test" if !KUNIT_ALL_TESTS
> > > +     depends on KUNIT
> > > +     default KUNIT_ALL_TESTS
> > > [SNAP...]
> >
> > --
> > You received this message because you are subscribed to the Google Groups "KUnit Development" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@...glegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/d7b2b598-7087-0445-4647-8521f3238dc2%40redhat.com.