linux-kernel - Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfogqstLpViF_+0YkAqFFTTHn0kt2j2n1Oe4CKVJUfPCQ@mail.gmail.com>
Date:   Tue, 4 May 2021 00:14:07 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "J. Bruce Fields" <bfields@...hat.com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-nfs@...r.kernel.org,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        "J. Bruce Fields" <bfields@...ldses.org>,
        Chuck Lever <chuck.lever@...cle.com>,
        Andy Shevchenko <andy@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem()

On Tue, May 4, 2021 at 12:11 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Tue, May 4, 2021 at 12:09 AM Al Viro <viro@...iv.linux.org.uk> wrote:
> > On Mon, May 03, 2021 at 11:56:41PM +0300, Andy Shevchenko wrote:
> > > On Mon, May 3, 2021 at 11:54 PM Al Viro <viro@...iv.linux.org.uk> wrote:

...

> > > Any suggestions how to replace that API with a newer one?
> >
> > seq_escape_mem(), perhaps?
>
> I think I have a better idea. What about adding seq_escape_with_flags()
> and seq_escape() --> seq_escape_with_flags(..., ESCAPE_OCTAL, ...) ?
>
> Would it work for you?

Ah, it wouldn't work for the user, because it wants to pass the buffer size.
Okay, I'll take your suggestion, thanks!

-- 
With Best Regards,
Andy Shevchenko