linux-kernel - Re: drivers/gpio/gpio-dwapb.c:678:12: warning: stack frame size of 2064 bytes in function 'dwapb_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOd=2vLrjzDnqeqA39BX-Wd+dn+UKPhRvzCjYR0js44y6BQ@mail.gmail.com>
Date:   Mon, 3 May 2021 16:39:13 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     kernel test robot <lkp@...el.com>,
        Luo Jiaxing <luojiaxing@...wei.com>, kbuild-all@...ts.01.org,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: drivers/gpio/gpio-dwapb.c:678:12: warning: stack frame size of
 2064 bytes in function 'dwapb_gpio_probe'

On Mon, May 3, 2021 at 1:49 PM Nick Desaulniers <ndesaulniers@...gle.com> wrote:
>
> On Mon, May 3, 2021 at 1:40 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > On Mon, May 3, 2021 at 1:54 AM kernel test robot <lkp@...el.com> wrote:
> > >
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   27787ba3fa4904422b3928b898d1bd3d74d98bea
> > > commit: 60593df667e087b009ee0fc20d92e9c4c096a9b5 gpio: dwapb: fix NULL pointer dereference at dwapb_gpio_suspend()
> > > date:   5 months ago
> > > config: powerpc64-randconfig-r026-20210430 (attached as .config)
> > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8f5a2a5836cc8e4c1def2bdeb022e7b496623439)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # install powerpc64 cross compiling tool for clang build
> > >         # apt-get install binutils-powerpc64-linux-gnu
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60593df667e087b009ee0fc20d92e9c4c096a9b5
> > >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > >         git fetch --no-tags linus master
> > >         git checkout 60593df667e087b009ee0fc20d92e9c4c096a9b5
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=powerpc64
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@...el.com>
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/gpio/gpio-dwapb.c:678:12: warning: stack frame size of 2064 bytes in function 'dwapb_gpio_probe' [-Wframe-larger-than=]
> > >    static int dwapb_gpio_probe(struct platform_device *pdev)
> > >               ^
> > >    1 warning generated.
> >
> > Another Clang bug?
>
> We have a KI with ASAN's requirements on additional stack usage for
> shadow stacks not being considered when making decisions whether or
> not to inline. Looks like KASAN isn't enabled by this randconfig;
> UBSAN is.  I don't know if UBSAN has similar additional stack usage to
> KASAN.
>
> I can reproduce this warning on mainline with:
> $ wget https://groups.google.com/group/clang-built-linux/attach/983d2ad77c1d/.config.gz\?part\=0.1
> -O - | gunzip > .config
> $ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang -j72
> drivers/gpio/gpio-dwapb.o
>
> If I enable CONFIG_DEBUG_INFO, then rebuild, I have a utility for
> helping track these down from parsing the DWARF debug info.
> Unfortunately, it depends on pyelftools which doesn't know any ppc64
> relocations; let me see if I can implement that real quick, which
> should help debug this further.

https://github.com/eliben/pyelftools/pull/360
-- 
Thanks,
~Nick Desaulniers