linux-kernel - Re: [PATCH v3 0/3] iio: sps30: add support for serial interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210503115026.06ee3d04@jic23-huawei>
Date:   Mon, 3 May 2021 11:50:26 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Tomasz Duszynski <tomasz.duszynski@...akon.com>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <lars@...afoo.de>,
        <robh+dt@...nel.org>
Subject: Re: [PATCH v3 0/3] iio: sps30: add support for serial interface

On Mon, 3 May 2021 08:00:11 +0200
Tomasz Duszynski <tomasz.duszynski@...akon.com> wrote:

> One can communicate with sensor either over i2c or serial interface.
> This series add support for the latter. And in order to do that existing
> codebase needs to be separated into core and interface specific
> components.

I've taken the view the dt binding change is trivial enough I don't 'need'
to wait for Rob to take a look (though of course any comments are welcome!)

As such, I've applied the series to the togreg branch of iio.git and pushed
it out as testing for the autobuilders to see if we missed anything.

Thanks,

Jonathan

> 
> v3:
> - add i2c device matching based on id table
> - constify structure
> - rephrase comment regarding reading serial number
> - check serial number length
> 
> v2:
> - simplify Kconfig by hiding core component selection
> - export symbols as GPL compatible
> - drop excessive ops wrappers
> - rework ops to use __be32
> - rework polling for measurements, sensor produces measurements within
>   1s so instead of polling just wait 1s
> - simplify frame ready condition (serial)
> - don't mix char with unsigned version
> - calculate checksum during frame validation (serial)
> - uncomment return status in frame validation (serial)
> - pass part name to probe instead of KBUILD_MODNAME
> 
> Tomasz Duszynski (3):
>   iio: sps30: separate core and interface specific code
>   iio: sps30: add support for serial interface
>   dt-bindings: iio: chemical: sps30: update binding with serial example
> 
>  .../iio/chemical/sensirion,sps30.yaml         |   7 +-
>  MAINTAINERS                                   |   2 +
>  drivers/iio/chemical/Kconfig                  |  27 +-
>  drivers/iio/chemical/Makefile                 |   2 +
>  drivers/iio/chemical/sps30.c                  | 269 ++---------
>  drivers/iio/chemical/sps30.h                  |  35 ++
>  drivers/iio/chemical/sps30_i2c.c              | 258 +++++++++++
>  drivers/iio/chemical/sps30_serial.c           | 431 ++++++++++++++++++
>  8 files changed, 804 insertions(+), 227 deletions(-)
>  create mode 100644 drivers/iio/chemical/sps30.h
>  create mode 100644 drivers/iio/chemical/sps30_i2c.c
>  create mode 100644 drivers/iio/chemical/sps30_serial.c
> 
> --
> 2.31.1
>