linux-kernel - Re: [PATCH] s390: fix detection of vector enhancements facility 1 vs. vector packed decimal facility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 May 2021 14:52:32 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Alexander Egorenkov <egorenar@...ux.ibm.com>,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH] s390: fix detection of vector enhancements facility 1
 vs. vector packed decimal facility

On Mon,  3 May 2021 14:12:44 +0200
David Hildenbrand <david@...hat.com> wrote:

> The PoP documents:
> 	134: The vector packed decimal facility is installed in the
> 	     z/Architecture architectural mode. When bit 134 is
> 	     one, bit 129 is also one.
> 	135: The vector enhancements facility 1 is installed in
> 	     the z/Architecture architectural mode. When bit 135
> 	     is one, bit 129 is also one.
> 
> Looks like we confuse the vector enhancements facility 1 ("EXT") with the
> Vector packed decimal facility ("BCD"). Let's fix the facility checks.
> 
> Detected while working on QEMU/tcg z14 support and only unlocking
> the vector enhancements facility 1, but not the vector packed decimal
> facility.
> 
> Fixes: 2583b848cad0 ("s390: report new vector facilities")
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: Sven Schnelle <svens@...ux.ibm.com>
> Cc: Alexander Egorenkov <egorenar@...ux.ibm.com>
> Cc: Niklas Schnelle <schnelle@...ux.ibm.com>
> Cc: Janosch Frank <frankja@...ux.ibm.com>
> Cc: linux-s390@...r.kernel.org
> Signed-off-by: David Hildenbrand <david@...hat.com>
> ---
>  arch/s390/kernel/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@...hat.com>