linux-kernel - Re: [PATCH 66/69] Revert "video: imsttfb: fix potential NULL pointer dereferences"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKmx_yihD_627jHHyuH+xpi3_iJ=ekXcoV5FT6NDRWJRg@mail.gmail.com>
Date:   Mon, 3 May 2021 08:41:28 -0500
From:   Rob Herring <robh@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kangjie Lu <kjlu@....edu>, Aditya Pakki <pakki001@....edu>,
        Finn Thain <fthain@...egraphics.com.au>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH 66/69] Revert "video: imsttfb: fix potential NULL pointer dereferences"

On Mon, May 3, 2021 at 7:01 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> This reverts commit 1d84353d205a953e2381044953b7fa31c8c9702d.
>
> Because of recent interactions with developers from @umn.edu, all
> commits from them have been recently re-reviewed to ensure if they were
> correct or not.
>
> Upon review, this commit was found to be incorrect for the reasons
> below, so it must be reverted.  It will be fixed up "correctly" in a
> later kernel change.
>
> The original commit here, while technically correct, did not fully
> handle all of the reported issues that the commit stated it was fixing,
> so revert it until it can be "fixed" fully.
>
> Note, ioremap() probably will never fail for old hardware like this, and
> if anyone actually used this hardware (a PowerMac era PCI display card),
> they would not be using fbdev anymore.
>
> Cc: Kangjie Lu <kjlu@....edu>
> Cc: Aditya Pakki <pakki001@....edu>
> Cc: Finn Thain <fthain@...egraphics.com.au>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Fixes: 1d84353d205a ("video: imsttfb: fix potential NULL pointer dereferences")
> Cc: stable <stable@...r.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/video/fbdev/imsttfb.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Rob Herring <robh@...nel.org>