linux-kernel - Re: [PATCH] KEYS: trusted: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 May 2021 17:56:12 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     trix@...hat.com
Cc:     jejb@...ux.ibm.com, zohar@...ux.ibm.com, dhowells@...hat.com,
        jmorris@...ei.org, serge@...lyn.com,
        linux-integrity@...r.kernel.org, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KEYS: trusted: fix memory leak

On Fri, Apr 30, 2021 at 11:58:10AM -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Static analysis reports this problem
> trusted-keys/trusted_tpm1.c:496:10: warning: Potential memory leak
>   return ret;
>          ^~~
> 
> In tpm_seal() some failure handling returns directly, without
> freeing memory.
> 
> Fixes: 5df16caada3f ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
> Signed-off-by: Tom Rix <trix@...hat.com>

Hi, thanks appreciate this but unfortunately applied Colin's fix already
:-/

/Jarkko