linux-kernel - Re: [RESEND PATCH v3 2/3] watchdog: f71808e_wdt: migrate to new kernel watchdog API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210503152854.GA624769@roeck-us.net>
Date:   Mon, 3 May 2021 08:28:54 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v3 2/3] watchdog: f71808e_wdt: migrate to new
 kernel watchdog API

On Mon, May 03, 2021 at 04:39:25PM +0200, Ahmad Fatoum wrote:
> Hello Guenter,
> 
> On 03.05.21 16:31, Guenter Roeck wrote:
> >> -static struct fintek_wdt watchdog = {
> >> -	.lock = __MUTEX_INITIALIZER(watchdog.lock),
> >> -};
> >> +static struct fintek_wdt watchdog;
> > 
> > This should really be allocated, and "watchdog" is a terrible variable name
> > even if static, especially given the previous patch.
> 
> I can add a follow up patch to change this. I maintained the old
> state of things here to make review easier.
> 
Odd argument. You changed all the function names (unnecessarily,
if you ask me) in the first patch of the series because they were
too generic in your opinion. That by itself added a lot of unnecessary
complexity to the review. And pretty much everything else changed
in this patch anyway.

Guenter