linux-kernel - Re: [PATCH] pinctrl: amd: Implement irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQZ30B7-0EJst0h26JzRKb15n+RKnv=FSpkngLTAcU4UChDjg@mail.gmail.com>
Date:   Mon, 3 May 2021 09:53:26 -0600
From:   Raul Rangel <rrangel@...omium.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        kramasub@...omium.org, Linus Walleij <linus.walleij@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: amd: Implement irq_set_wake

On Fri, Apr 30, 2021 at 3:22 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Fri, Apr 30, 2021 at 1:34 AM Raul E Rangel <rrangel@...omium.org> wrote:
> >
> > This allows the OS to control which devices produce wake events.
> >
> > $ grep enabled /sys/kernel/irq/*/wakeup
> > /sys/kernel/irq/24/wakeup:enabled
>
> Is it a bug fix of [1]?
>
> If so, add a BugLink: tag here.

No bug, just implementing a missing feature. This allows the use of
the ACPI _AEI object.
>
> > Signed-off-by: Raul E Rangel <rrangel@...omium.org>
>
> [1]:
>
> ...
>
> irq_hw_number_t hw = irqd_to_hwirq(d);
>
> > +       pin_reg = readl(gpio_dev->base + (d->hwirq)*4);
>
> > +       writel(pin_reg, gpio_dev->base + (d->hwirq)*4);
>
> Too many parentheses and missed spaces

I copy/pasted the exact format used in all the other functions:
amd_gpio_irq_{enable,disable,mask,unmask}. I can send a CL to reformat
everything if you want. Or I can just change this specific function.
Let me know.

>
>
> --
> With Best Regards,
> Andy Shevchenko

Thanks for the review!