linux-kernel - Re: [PATCH] staging: rtl8723bs: Use list iterators and helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 May 2021 10:37:09 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Use list iterators and helpers

On 5/3/21 9:48 AM, Greg Kroah-Hartman wrote:
> On Wed, Apr 28, 2021 at 10:33:01AM -0700, Guenter Roeck wrote:  
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
>> index 85663182b388..9cb2c7a112d2 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
>> @@ -124,11 +124,8 @@ void kfree_all_stainfo(struct sta_priv *pstapriv)
>>  	spin_lock_bh(&pstapriv->sta_hash_lock);
>>  
>>  	phead = get_list_head(&pstapriv->free_sta_queue);
>> -	plist = get_next(phead);
>> -
>> -	while (phead != plist) {
>> -		psta = container_of(plist, struct sta_info, list);
>> -		plist = get_next(plist);
>> +	list_for_each(plist, phead) {
>> +		psta = list_entry(plist, struct sta_info, list);
>>  	}
>>  
>>  	spin_unlock_bh(&pstapriv->sta_hash_lock);
> 
> 
> This chunk didn't apply to my tree as someone else cleaned something in
> this function.
> 
> But that doesn't even really matter as this function does nothing at
> all!
> 

You are correct. Weird.

Guenter