linux-kernel - Re: linux-next failing build due to missing cubictcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e051459-8532-7b61-c815-f3435767f8a0@kernel.org>
Date:   Mon, 3 May 2021 09:59:37 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Michal Suchánek <msuchanek@...e.de>,
        Jiri Olsa <jolsa@...hat.com>
Cc:     Yonghong Song <yhs@...com>, linux-kernel@...r.kernel.org,
        Martin KaFai Lau <kafai@...com>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: linux-next failing build due to missing cubictcp_state symbol

On 03. 05. 21, 8:11, Jiri Slaby wrote:
>>>>>> looks like vfs_truncate did not get into BTF data,
>>>>>> I'll try to reproduce
>>
>> _None_ of the functions are generated by pahole -J from debuginfo on 
>> ppc64. debuginfo appears to be correct. Neither pahole -J fs/open.o 
>> works correctly. collect_functions in dwarves seems to be defunct on 
>> ppc64... "functions" array is bogus (so find_function -- the bsearch 
>> -- fails).
> 
> It's not that bogus. I forgot an asterisk:
>> #0  find_function (btfe=0x100269f80, name=0x10024631c "stream_open") 
>> at /usr/src/debug/dwarves-1.21-1.1.ppc64/btf_encoder.c:350
>> (gdb) p (*functions)@84
>> $5 = {{name = 0x7ffff68e0922 ".__se_compat_sys_ftruncate", addr = 
>> 75232, size = 72, sh_addr = 65536, generated = false}, {
>>     name = 0x7ffff68e019e ".__se_compat_sys_open", addr = 80592, size 
>> = 216, sh_addr = 65536, generated = false}, {
>>     name = 0x7ffff68e0076 ".__se_compat_sys_openat", addr = 80816, 
>> size = 232, sh_addr = 65536, generated = false}, {
>>     name = 0x7ffff68e0908 ".__se_compat_sys_truncate", addr = 74304, 
>> size = 100, sh_addr = 65536, generated = false}, {
> ...
>>     name = 0x7ffff68e0808 ".stream_open", addr = 65824, size = 72, 
>> sh_addr = 65536, generated = false}, {
> ...
>>     name = 0x7ffff68e0751 ".vfs_truncate", addr = 73392, size = 544, 
>> sh_addr = 65536, generated = false}}
> 
> The dot makes the difference, of course. The question is why is it 
> there? I keep looking into it. Only if someone has an immediate idea...

Well, .vfs_truncate is in .text (and contains an ._mcount call). And 
vfs_truncate is in .opd (w/o an ._mcount call). Since setup_functions 
excludes all functions without the ._mcount call, is_ftrace_func later 
returns false for such functions and they are filtered before the BTF 
processing.

Technically, get_vmlinux_addrs looks at a list of functions between 
__start_mcount_loc and __stop_mcount_loc and considers only the listed.

I don't know what the correct fix is (exclude .opd functions from the 
filter?). Neither why cross compiler doesn't fail, nor why ebi v2 avoids 
this too.

regards,
-- 
js