linux-kernel - Re: [PATCH v4] KVM: x86: Fix KVM_GET_CPUID2 ioctl to return cpuid entries count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4434730-9cd1-1d41-d012-f7beff7e351b@amazon.com>
Date:   Tue, 4 May 2021 11:26:20 +0200
From:   Alexander Graf <graf@...zon.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        "Denis V. Lunev" <den@...nvz.org>,
        Sean Christopherson <seanjc@...gle.com>,
        Valeriy Vdovin <valeriy.vdovin@...tuozzo.com>
CC:     <linux-kernel@...r.kernel.org>, Jonathan Corbet <corbet@....net>,
        "Vitaly Kuznetsov" <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        "Jim Mattson" <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "Borislav Petkov" <bp@...en8.de>, <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Shuah Khan <shuah@...nel.org>,
        Aaron Lewis <aaronlewis@...gle.com>,
        "Andrew Jones" <drjones@...hat.com>,
        Oliver Upton <oupton@...gle.com>,
        Like Xu <like.xu@...ux.intel.com>, <kvm@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v4] KVM: x86: Fix KVM_GET_CPUID2 ioctl to return cpuid
 entries count



On 04.05.21 10:21, Paolo Bonzini wrote:
> 
> On 04/05/21 10:15, Denis V. Lunev wrote:
>> As far as I understand only some testing within kernel now.
>> Though we have plans to expose it for QAPI as the series
>> in QEMU
>>    [PATCH 1/2] qapi: fix error handling for x-vz-query-cpu-model-cpuid
>>    [PATCH 2/2] qapi: blacklisted x-vz-query-cpu-model-cpuid in tests
>> is not coming in a good way.
>> The idea was to avoid manual code rework in QEMU and
>> expose collected model at least for debug.
> 
> KVM_GET_CPUID2 as a VM ioctl cannot expose the whole truth about CPUID
> either, since it doesn't handle the TSX_CTRL_CPUID_CLEAR bit.  Given
> that QEMU doesn't need KVM_GET_CPUID2; it only needs to save whatever it
> passed to KVM_SET_CPUID2.

What if we instead deflect CPUID into user space so it can emulate it in 
whatever way it likes? Is the performance difference going to be 
relevant? Are people still using cpuid as barrier these days?


Alex



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879