linux-kernel - Re: [PATCH v2] gpio: wcd934x: Fix shift-out-of-bounds error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e50f575c-9726-d8e3-4762-c25813cb76c3@linaro.org>
Date:   Tue, 4 May 2021 13:37:43 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     linus.walleij@...aro.org, linux-gpio@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, john.stultz@...aro.org,
        amit.pundir@...aro.org, bjorn.andersson@...aro.org,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v2] gpio: wcd934x: Fix shift-out-of-bounds error

Hi Linus,

On 10/03/2021 17:43, Srinivas Kandagatla wrote:
> bit-mask for pins 0 to 4 is BIT(0) to BIT(4) however we ended up with BIT(n - 1)
> which is not right, and this was caught by below usban check
> 
> UBSAN: shift-out-of-bounds in drivers/gpio/gpio-wcd934x.c:34:14
> 
> Fixes: 59c324683400 ("gpio: wcd934x: Add support to wcd934x gpio controller")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ---

Looks like this patch was missed. Without this audio on DragonBoard 
DB845c is broken once rc1 is out, as the corresponding dts changes are 
already in next.

Any chance to get this in .. maybe after rc1?


--srini

> changes since v1:
> 	- removed unnecessary dump stack from log
> 
>   drivers/gpio/gpio-wcd934x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c
> index 1cbce5990855..97e6caedf1f3 100644
> --- a/drivers/gpio/gpio-wcd934x.c
> +++ b/drivers/gpio/gpio-wcd934x.c
> @@ -7,7 +7,7 @@
>   #include <linux/slab.h>
>   #include <linux/of_device.h>
>   
> -#define WCD_PIN_MASK(p) BIT(p - 1)
> +#define WCD_PIN_MASK(p) BIT(p)
>   #define WCD_REG_DIR_CTL_OFFSET 0x42
>   #define WCD_REG_VAL_CTL_OFFSET 0x43
>   #define WCD934X_NPINS		5
>