linux-kernel - Re: [PATCH 2/2] dt-bindings: input: Add binding for cypress-sf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1620136537.083522.4044729.nullmailer@robh.at.kernel.org>
Date:   Tue, 04 May 2021 08:55:37 -0500
From:   Rob Herring <robh@...nel.org>
To:     Yassine Oudjana <y.oudjana@...tonmail.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "phone-devel@...r.kernel.org" <phone-devel@...r.kernel.org>,
        "~postmarketos/upstreaming@...ts.sr.ht" 
        <~postmarketos/upstreaming@...ts.sr.ht>
Subject: Re: [PATCH 2/2] dt-bindings: input: Add binding for cypress-sf

On Tue, 04 May 2021 08:48:26 +0000, Yassine Oudjana wrote:
> Add a device tree binding for Cypress StreetFighter.
> ---
>  .../devicetree/bindings/input/cypress-sf.yaml | 55 +++++++++++++++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/cypress-sf.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/cypress-sf.yaml: 'maintainers' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/cypress-sf.yaml: ignoring, error in schema: 
warning: no schema found in file: ./Documentation/devicetree/bindings/input/cypress-sf.yaml
Documentation/devicetree/bindings/input/cypress-sf.example.dt.yaml:0:0: /example-0/i2c/touchkey@28: failed to match any schema with compatible: ['cypress,sf3155']

See https://patchwork.ozlabs.org/patch/1473675

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.