linux-kernel - Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 May 2021 18:11:53 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI

On Tue, May 4, 2021 at 5:41 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> With CONFIG_ACPI=n and -Werror, 0-day reports:
>
> drivers/iio/humidity/am2315.c:259:36: error:
>         'am2315_acpi_id' defined but not used

...

> +#ifdef CONFIG_ACPI
>  static const struct acpi_device_id am2315_acpi_id[] = {
>         {"AOS2315", 0},

This is a fake ID according to the specification. Do we have any proof
that it's being used in the wild?
If no, I prefer to drop this ID section entirely.

If yes, needs a comment which device is using it (however it may be
out of the scope of this fix).

>         {}
>  };
> -
>  MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> +#endif

-- 
With Best Regards,
Andy Shevchenko