linux-kernel - Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 May 2021 08:34:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI

Hi Andy,

On Tue, May 04, 2021 at 06:15:44PM +0300, Andy Shevchenko wrote:
> On Tue, May 4, 2021 at 6:11 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > On Tue, May 4, 2021 at 5:41 PM Guenter Roeck <linux@...ck-us.net> wrote:
> > >
> > > With CONFIG_ACPI=n and -Werror, 0-day reports:
> > >
> > > drivers/iio/humidity/am2315.c:259:36: error:
> > >         'am2315_acpi_id' defined but not used
> >
> > ...
> >
> > > +#ifdef CONFIG_ACPI
> > >  static const struct acpi_device_id am2315_acpi_id[] = {
> > >         {"AOS2315", 0},
> >
> > This is a fake ID according to the specification. Do we have any proof
> > that it's being used in the wild?
> > If no, I prefer to drop this ID section entirely.
> >
> > If yes, needs a comment which device is using it (however it may be
> > out of the scope of this fix).
> 
> Googling shows zarro results.
> 
> (Yes, I know about meta-acpi project and I may fix it there, but it
> may not be considered as a "being in the wild")
> 
> So, please, remove the entire section.
> 
I'll send v2.

> Feel free to add any tag from me (Rb, Ack)
> 
Since the change is substantial, I don't feel comfortable doing that.
I'll copy you on v2 and let you add the tags yourself.

Thanks,
Guenter

> > >         {}
> > >  };
> > > -
> > >  MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> > > +#endif
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko