linux-kernel - Re: [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek, gce-events property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1620101459.15918.4.camel@mtksdaap41>
Date:   Tue, 4 May 2021 12:10:59 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     Hsin-Yi Wang <hsinyi@...omium.org>
CC:     Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        <devicetree@...r.kernel.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek,
 gce-events property

Hi, Hsin-yi:

On Mon, 2021-05-03 at 13:05 +0800, Hsin-Yi Wang wrote:
> mediatek,gce-events property is used by gce clients.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
> ---
>  .../devicetree/bindings/display/mediatek/mediatek,disp.txt  | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index fbb59c9ddda6..939b2da3bdc5 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -75,6 +75,10 @@ Optional properties (RDMA function blocks):
>    mediatek,rdma-fifo-size of mt8183-rdma0 is 5K
>    mediatek,rdma-fifo-size of mt8183-rdma1 is 2K
>  
> +Optional properties for display mutex:
> +- mediatek,gce-events: GCE events used by clients. The event numbers are
> +  defined in 'dt-bindings/gce/<chip>-gce.h'.

I think mediatek,gce-events should be first defined in [1], and here
refer to [1].

In addition, mtk-mutex driver is moved into soc folder, so I would like
to move mtk-mutex binding out of display binding. It's up to you.

[1] Documentation/devicetree/bindings/mailbox/mtk-gce.txt

Regards,
CK

> +
>  Examples:
>  
>  mmsys: clock-controller@...00000 {
> @@ -209,6 +213,8 @@ mutex: mutex@...20000 {
>  	interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_LOW>;
>  	power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
>  	clocks = <&mmsys CLK_MM_MUTEX_32K>;
> +	mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
> +			      <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
>  };
>  
>  od@...23000 {