linux-kernel - Re: [PATCH v3] tee: amdtee: unload TA only when its refcount becomes 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01387b92-263c-edf1-52bf-b2244ebbd311@amd.com>
Date:   Tue, 4 May 2021 09:56:10 +0530
From:   Rijo Thomas <Rijo-john.Thomas@....com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Jens Wiklander <jens.wiklander@...aro.org>,
        Devaraj Rangasamy <Devaraj.Rangasamy@....com>,
        Mythri Pandeshwara krishna <mythri.pandeshwarakrishna@....com>,
        op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] tee: amdtee: unload TA only when its refcount becomes
 0



On 03/05/21 5:17 pm, Dan Carpenter wrote:
> On Mon, May 03, 2021 at 09:04:35AM +0530, Rijo Thomas wrote:
>>
>>
>> On 14/04/21 11:08 pm, Rijo Thomas wrote:
>>> Same Trusted Application (TA) can be loaded in multiple TEE contexts.
>>>
>>> If it is a single instance TA, the TA should not get unloaded from AMD
>>> Secure Processor, while it is still in use in another TEE context.
>>>
>>> Therefore reference count TA and unload it when the count becomes zero.
>>>
>>> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
>>> Reviewed-by: Devaraj Rangasamy <Devaraj.Rangasamy@....com>
>>> Signed-off-by: Rijo Thomas <Rijo-john.Thomas@....com>
>>
>> Hi Dan,
>>
>> Can you please give an Ack if you are okay with this patch.
>> I have incorporated your review comments for v2.
>>
> 
> Oh, Sorry.  Thanks!
> 
> Acked-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks Dan!

Jens, can you please pull in this patch.

Thanks,
Rijo

> 
> regards,
> dan carpenter
>