linux-kernel - Re: [PATCH v1 6/6] bus: mhi: core: Add range checks for BHI and BHIe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5e8cd2e-2863-f88b-8344-021d90a68131@quicinc.com>
Date:   Tue, 4 May 2021 11:30:59 -0600
From:   Jeffrey Hugo <quic_jhugo@...cinc.com>
To:     Bhaumik Bhatt <bbhatt@...eaurora.org>,
        <manivannan.sadhasivam@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>, <hemantk@...eaurora.org>,
        <linux-kernel@...r.kernel.org>, <loic.poulain@...aro.org>,
        <linux-wireless@...r.kernel.org>, <kvalo@...eaurora.org>,
        <ath11k@...ts.infradead.org>
Subject: Re: [PATCH v1 6/6] bus: mhi: core: Add range checks for BHI and BHIe

On 4/16/2021 12:47 PM, Bhaumik Bhatt wrote:
> When obtaining the BHI or BHIe offsets during the power up
> preparation phase, range checks are missing. These can help
> controller drivers avoid accessing any address outside of the
> MMIO region. Ensure that mhi_cntrl->reg_len is set before MHI
> registration as it is a required field and range checks will
> fail without it.
> 
> Signed-off-by: Bhaumik Bhatt <bbhatt@...eaurora.org>
> ---

Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>