linux-kernel - Re: [PATCH v2 2/2] platform/x86: samsung-laptop: set debugfs blobs to read only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc8OGDB0=ta_GLg3Bjv5NK32dMuuaPTX-ETXRDHtRpxnA@mail.gmail.com>
Date:   Tue, 4 May 2021 20:38:24 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Corentin Chary <corentin.chary@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] platform/x86: samsung-laptop: set debugfs blobs to
 read only

On Tue, May 4, 2021 at 8:18 PM Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
>
> Those blobs can only be read. So, don't confuse users with 'writable'
> flags.

Not sure if this should be the second patch in the series (sounds like
a potential fix).
Either way
Reviewed-by: Andy Shevchenko <andy.shevchneko@...il.com>

> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>
> Change since v1: use octal numbers
>
>  drivers/platform/x86/samsung-laptop.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index 763d97cbbe53..9aa0de8b7581 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -1296,12 +1296,12 @@ static void samsung_debugfs_init(struct samsung_laptop *samsung)
>         debugfs_create_u32("d1", 0644, root, &samsung->debug.data.d1);
>         debugfs_create_u16("d2", 0644, root, &samsung->debug.data.d2);
>         debugfs_create_u8("d3", 0644, root, &samsung->debug.data.d3);
> -       debugfs_create_blob("data", 0644, root, &samsung->debug.data_wrapper);
> -       debugfs_create_blob("f0000_segment", 0600, root,
> +       debugfs_create_blob("data", 0444, root, &samsung->debug.data_wrapper);
> +       debugfs_create_blob("f0000_segment", 0400, root,
>                             &samsung->debug.f0000_wrapper);
>         debugfs_create_file("call", S_IFREG | 0444, root, samsung,
>                             &samsung_laptop_call_fops);
> -       debugfs_create_blob("sdiag", 0644, root, &samsung->debug.sdiag_wrapper);
> +       debugfs_create_blob("sdiag", 0444, root, &samsung->debug.sdiag_wrapper);
>  }
>
>  static void samsung_sabi_exit(struct samsung_laptop *samsung)
> --
> 2.30.0
>


-- 
With Best Regards,
Andy Shevchenko