linux-kernel - Re: [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f8b6f33-4308-bfda-2238-9a54e19c3f9f@roeck-us.net>
Date:   Tue, 4 May 2021 11:00:52 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on
 CONFIG_ACPI

On 5/4/21 10:44 AM, Andy Shevchenko wrote:
> On Tue, May 4, 2021 at 8:40 PM Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> With CONFIG_ACPI=n and -Werror, 0-day reports:
>>
>> drivers/iio/chemical/bme680_i2c.c:46:36: error:
>>         'bme680_acpi_match' defined but not used
> 
>> Given the other patch, question of course is if this ACPI ID
>> is real. A Google search suggests that this might not be the case.
>> Should we remove it as well ? STK8312 has the same problem.
> 
> For this one definitely removal. Looking into the code it suggests a
> cargo cult taken that time by a few contributors to invent fake ACPI
> IDs while submitting new drivers.
> Feel free to add my tag or if you wish me I'll add it explicitly.
> 

I'll resend and let you add the tag, and send a similar patch
for STK8312. I'll wait until tomorrow, though - I sent a number of
patches today already, and I want to avoid yet another "account
suspended" notice from gmail.

Thanks,
Guenter