linux-kernel - Re: [PATCH 2/2] x86/MCE: Don't call kill_me

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210504182954.GA25053@aus-x-yghannam.amd.com>
Date:   Tue, 4 May 2021 14:29:54 -0400
From:   Yazen Ghannam <yazen.ghannam@....com>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, Smita.KoralahalliChannabasappa@....com,
        stable@...r.kernel.org
Subject: Re: [PATCH 2/2] x86/MCE: Don't call kill_me_now() directly

On Tue, May 04, 2021 at 11:07:34AM -0700, Luck, Tony wrote:
> On Tue, May 04, 2021 at 05:47:12PM +0000, Yazen Ghannam wrote:
...
> > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
> > index 308fb644b94a..9040d45ed997 100644
> > --- a/arch/x86/kernel/cpu/mce/core.c
> > +++ b/arch/x86/kernel/cpu/mce/core.c
> > @@ -1285,10 +1285,7 @@ static void queue_task_work(struct mce *m, int kill_current_task)
> >  	current->mce_ripv = !!(m->mcgstatus & MCG_STATUS_RIPV);
> >  	current->mce_whole_page = whole_page(m);
> >  
> > -	if (kill_current_task)
> > -		current->mce_kill_me.func = kill_me_now;
> > -	else
> > -		current->mce_kill_me.func = kill_me_maybe;
> > +	current->mce_kill_me.func = kill_me_maybe;
> >  
> >  	task_work_add(current, &current->mce_kill_me, TWA_RESUME);
> >  }
> 
> Could we just get rid of kill_me_now() at the same time? It's only
> one line, and with this change only called in one place (from
> kill_me_maybe()) ... just put the force_sig(SIGBUS); inline?
>

Okay, will do.

Thanks,
Yazen