linux-kernel - Re: [PATCH] checkpatch: do not check for "/dev/null" while parsing addition of files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 05 May 2021 10:17:13 -0700
From:   Joe Perches <joe@...ches.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        akpm@...ux-foundation.org, apw@...onical.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: do not check for "/dev/null" while parsing
 addition of files

On Wed, 2021-05-05 at 13:42 +0530, Manivannan Sadhasivam wrote:
> "/dev/null" is used to signal created or deleted files in the diff header.
> While parsing the addition of files, checkpatch should look for
> "+++ b/file" and ignore "+++ /dev/null".

nack.  checkpatch shouldn't care about a/ b/ uses here.

> 
> Without this change, checkpatch falsely reports below warning for the
> patch that does devicetree YAML conversion:

Send me a copy of the source patch that creates this false positive.

> 
> ```
> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst