linux-kernel - Re: [PATCH 0/5] x86/kvm: Refactor KVM PV features teardown and fix restore from hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 May 2021 17:27:02 +0000
From:   "Aboubakr, Mohamed" <mabouba@...zon.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
CC:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        Sean Christopherson <seanjc@...gle.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        "x86@...nel.org" <x86@...nel.org>,
        Lenny Szubowicz <lszubowi@...hat.com>,
        "Chen, Xiaoyi" <cxiaoyi@...zon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/5] x86/kvm: Refactor KVM PV features teardown and fix restore
 from hibernation

Hello,

Confirmed c5.18xlarge and c5a.18xlarge issue has been fixed by this patch. 

Thanks 
Mohamed Aboubakr
> On May 3, 2021, at 8:26 AM, Paolo Bonzini <pbonzini@...hat.com> wrote:
> 
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
>> On 14/04/21 14:35, Vitaly Kuznetsov wrote:
>> This series is a successor of Lenny's "[PATCH] x86/kvmclock: Stop kvmclocks
>> for hibernate restore". While reviewing his patch I realized that PV
>> features teardown we have is a bit messy: it is scattered across kvm.c
>> and kvmclock.c and not all features are being shutdown an all paths.
>> This series unifies all teardown paths in kvm.c and makes sure all
>> features are disabled when needed.
>> 
>> Vitaly Kuznetsov (5):
>>   x86/kvm: Fix pr_info() for async PF setup/teardown
>>   x86/kvm: Teardown PV features on boot CPU as well
>>   x86/kvm: Disable kvmclock on all CPUs on shutdown
>>   x86/kvm: Disable all PV features on crash
>>   x86/kvm: Unify kvm_pv_guest_cpu_reboot() with kvm_guest_cpu_offline()
>> 
>>  arch/x86/include/asm/kvm_para.h |  10 +--
>>  arch/x86/kernel/kvm.c           | 113 +++++++++++++++++++++-----------
>>  arch/x86/kernel/kvmclock.c      |  26 +-------
>>  3 files changed, 78 insertions(+), 71 deletions(-)
>> 
> 
> Queuing this patch, thanks.
> 
> If the Amazon folks want to provide their Tested-by (since they looked
> at it before and tested Lenny's first attempt at using syscore_ops),
> they're still in time!
> 
> Paolo
>