linux-kernel - Re: [PATCH] dt-bindings: i2c: Move i2c-omap.txt to YAML format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 May 2021 23:34:46 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Tony Lindgren <tony@...mide.com>
CC:     Rob Herring <robh+dt@...nel.org>, <linux-omap@...r.kernel.org>,
        <linux-i2c@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Nishanth Menon <nm@...com>
Subject: Re: [PATCH] dt-bindings: i2c: Move i2c-omap.txt to YAML format

Hi,

On 5/5/21 12:48 PM, Tony Lindgren wrote:
> Hi,
> 
> * Vignesh Raghavendra <vigneshr@...com> [210505 06:55]:
>> Convert i2c-omap.txt to YAML schema for better checks and documentation.
> 
> Nice to see this happening, few minor comments below on handling the
> legacy devices.
> 
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: ti,omap2420-i2c
>> +      - const: ti,omap2430-i2c
>> +      - const: ti,omap3-i2c
>> +      - const: ti,omap4-i2c
>> +      - items:
>> +          - enum:
>> +              - ti,am4372-i2c
>> +              - ti,am64-i2c
>> +              - ti,am654-i2c
>> +              - ti,j721e-i2c
>> +          - const: ti,omap4-i2c
> 
> I wonder if we should just add all the compatible options to the
> driver, and have all these as oneOf?
> 

This would also need updates to dts files too. Also not a fan of adding
all compatibles to driver code unless required.

>> +  ti,hwmods:
>> +    description:
>> +      Must be "i2c<n>", n being the instance number (1-based)
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    items:
>> +      - pattern: "^i2c([1-9])$"
> 
> The ti,hwmods is a legacy property that is only needed for omap2/3 and
> ti81xx. At least the description should mention that to avoid folks
> adding it accidentally.
> 

Sure, will do in v2. Thanks for the review!


Regards
Vignesh