linux-kernel - RE: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 May 2021 19:02:14 +0000
From:   "Lei Wang (DPLAT)" <Wang.Lei@...rosoft.com>
To:     Borislav Petkov <bp@...en8.de>, wangglei <wangglei@...il.com>
CC:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "james.morse@....com" <james.morse@....com>,
        "rric@...nel.org" <rric@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hang Li <hangl@...rosoft.com>,
        "tyhicks@...ux.microsoft.com" <tyhicks@...ux.microsoft.com>,
        Brandon Waller <bwaller@...rosoft.com>
Subject: RE: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use
 printk_ratelimited.

Hi Boris,

We found a corner case in production environment that there are ~500 CE errors per second. The SoC otherwise functions just fine. Making printk ratelimited reduced CE error logging to < 20 per second. Though this is just one case so far, we think moving to printk_ratelimited could benefit broader use as well, by helping control the amount of kernel logging. In most running condition, the error rate is way below the limit. And in an error case like this one, vast error logging would not provide much valuable details, rather it's storming the kernel logging.

Thanks,
-Lei

-----Original Message-----
From: Borislav Petkov <bp@...en8.de> 
Sent: Wednesday, May 5, 2021 11:01 AM
To: wangglei <wangglei@...il.com>
Cc: mchehab@...nel.org; tony.luck@...el.com; james.morse@....com; rric@...nel.org; linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; Lei Wang (DPLAT) <Wang.Lei@...rosoft.com>; Hang Li <hangl@...rosoft.com>; tyhicks@...ux.microsoft.com; Brandon Waller <bwaller@...rosoft.com>
Subject: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited.

On Wed, May 05, 2021 at 10:30:27AM -0700, Lei Wang wrote:
> Update printk to the ratelimited version, so that in some corner cases 
> when vast of CE errors show up, the kernel logging can be suppressed.

Err, why?

--
Regards/Gruss,
    Boris.

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette&amp;data=04%7C01%7CWang.Lei%40microsoft.com%7C71421584bc2a43951df908d90fefc1b9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637558344708605379%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=fJG0%2Fdk8VCVNIGS0kM2BZDHAXLVcq4CLHEajhND0rzg%3D&amp;reserved=0